fix: restore SLI 'No Data' badge lost in merge#44
Merged
TerrifiedBug merged 1 commit intomainfrom Mar 7, 2026
Merged
Conversation
When SLIs are configured but the pipeline has no traffic yet, show a gray "No Data" badge instead of hiding the indicator entirely. This was lost during the merge of PR #33 due to conflict resolution.
Contributor
Greptile SummaryThis PR restores the "No Data" gray-dot health badge for pipelines that have SLIs configured but haven't received traffic yet — a behavior lost during the merge of PR #33. The fix adds a
The logic is sound and the implementation is minimal and focused. The change is a 16-line addition to a single frontend component plus supporting UI updates (tag badges, table column). Confidence Score: 5/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PipelineHealthBadge renders] --> B{healthQuery.data\ndefined?}
B -- No / loading --> C[return null\nhide badge]
B -- Yes --> D{status}
D -- null --> C
D -- no_data --> E{hasSlis?\nslis.length > 0}
E -- true\nSLIs configured\nbut no traffic --> F[Gray dot\nTooltip: 'No Data — SLIs configured\nbut no traffic yet']
E -- false\nNo SLIs configured --> C
D -- healthy --> G[Green dot\nTooltip: 'All SLIs met']
D -- degraded --> H[Yellow dot\nTooltip: 'One or more SLIs breached']
Last reviewed commit: 2c7ac34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PipelineHealthBadgenow distinguishes between "No SLIs configured" (hidden) and "SLIs configured but no traffic" (gray dot with "No Data" tooltip)Test plan
npx tsc --noEmitpasses